You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The original IntrusiveSingleList had a splice method that was removed in the refactor. The new SingleLinkListImpl does not expose a splice operation, and the wrapper IntrusiveSingleList does not provide one either. If any caller relied on splice, this change will break compilation or require rework. Verify that splice is no longer needed or add it to the new implementation.
The original IntrusiveDoubleList had a splice method that is absent in the refactored DoubleLinkListImpl and its wrapper IntrusiveDoubleList. If any existing code uses splice, it will fail to compile. Confirm that splice is intentionally removed or re-add it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Refactored intrusive list to separate implementation from type-safe wrapper
Extracted
SingleLinkListImplandDoubleLinkListImplas non-template base classesMoved template logic into new
IntrusiveSingleListandIntrusiveDoubleListwrappersUpdated
splicemethod to clear source list after moving entriesDiagram Walkthrough
File Walkthrough
intrusive.hpp
Refactored intrusive list into impl and wrapperinclude/condy/detail/intrusive.hpp
SingleLinkListImplandDoubleLinkListImplas non-templateclasses
IntrusiveSingleListandIntrusiveDoubleListspliceto clear source list after moving entriespush_back,pop_front, andremoveto accept raw entry pointers